Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focusing VS Search (Ctrl+Q) causes an error dialog when no files are open #2

Closed
olegtk opened this issue Apr 21, 2021 · 1 comment
Closed

Comments

@olegtk
Copy link
Contributor

olegtk commented Apr 21, 2021

See https://developercommunity.visualstudio.com/t/Quick-Search-gives-immediate-error-when-/1374751

We identified the issues is caused by NullReferenceException in DiffClipboardWithCodeCommand.OnBeforeQueryStatus() and then BaseCommand.OnBaseBeforeQueryStatus() showing an error dialog.

Please don't show any dialogs during QueryStatus calls, they are intended to be very fast and have no side effects except modifying command state.
Thanks!

Name

Throw(System.NullReferenceException) Object reference not set to an instance of an object.

  • clr!EtwCallout
  • clr!CoTemplate_zzpqhh
  • clr!ETW::ExceptionLog::ExceptionThrown
  • clr!COMPlusThrowCallback
  • clr!Thread::StackWalkFramesEx
  • clr!Thread::StackWalkFrames
  • clr!CPFH_RealFirstPassHandler
  • clr!CPFH_FirstPassHandler
  • clr!_COMPlusFrameHandler
  • clr!_COMPlusFrameHandlerRevCom
  • ntdll!ExecuteHandler2
  • ntdll!ExecuteHandler
  • ntdll!KiUserExceptionDispatcher
  • Kool.VsDiff!DiffClipboardWithCodeCommand.OnBeforeQueryStatus
    |+ Kool.VsDiff!BaseCommand.OnBaseBeforeQueryStatus
    ...
@heku
Copy link
Owner

heku commented Apr 22, 2021

Thanks for your suggestion and code fix, I'll merge it soon.

@heku heku closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants