Make search case insensitive. Fix for taskcluster 1754 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameter caseInsensitiveSearch Change search functionality to use regular expression instead of string Fix StyleGuide import path Add babel-plugin-transform-es2015-modules-commonjs and babel-plugin-transform-object-rest-spread to yarn devDependencies
Add descrition of new parameter caseInsensitiveSearch to ReadMe file
|
@helfi92 Please, review |
helfi92
reviewed
Nov 13, 2019
Rebase cause a big merge conflict. So I'll take a look during a weekends. |
|
You can always close this pr and open a new one. It might be easier since there will be no code conflict. |
|
@helfi92 you're right! it will be more logical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter caseInsensitiveSearch
Change search functionality(
filter(tree)) to use regular expression instead of stringFix StyleGuide import path
Add babel-plugin-transform-es2015-modules-commonjs and babel-plugin-transform-object-rest-spread to yarn devDependencies
Checklist
yarn lintto see the errors andyarn lint --fixto fix them)README.mdif requiredsrc/index.d.tsif any exposed properties are removed/added