Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Do not use retry to fix the test; stats are approximate; just check for existence, not values #5112

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Oct 6, 2022

Resolves #5111
See PR #5109 for explanation.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

…h instead

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno added this to the 3.0.2 milestone Oct 6, 2022
@tjquinno tjquinno self-assigned this Oct 6, 2022
@tjquinno tjquinno changed the title Do not use retry to fix the test; use the pre-existing countdown latch instead [3.x] Do not use retry to fix the test; use the pre-existing countdown latch instead Oct 6, 2022
@tjquinno tjquinno added the 3.x Issues for 3.x version branch label Oct 6, 2022
@tjquinno tjquinno marked this pull request as draft October 6, 2022 23:08
@tjquinno tjquinno marked this pull request as ready for review October 7, 2022 19:20
@tjquinno tjquinno changed the title [3.x] Do not use retry to fix the test; use the pre-existing countdown latch instead [3.x] Do not use retry to fix the test; stats are approximate; just check for existence, not values Oct 7, 2022
@tjquinno tjquinno merged commit 5f4202e into helidon-io:helidon-3.x Oct 10, 2022
@tjquinno tjquinno deleted the metrics-test-fixes-3.x branch October 10, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] Intermittent TestServer.checkMetricsForExecutorService
2 participants