Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Use text blocks in tests #7354

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Captain1653
Copy link
Contributor

@Captain1653 Captain1653 commented Aug 10, 2023

There are many lines in the code:


String value = "some text\n" +
"other text\n" +
"third text\n";

I think it can be replaced on text blocks.

I used IDE conversion.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 10, 2023
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Captain1653, thanks for the contribution.
This one is under the "we know we can, the question is if we should".
I am approving this PR, as you have invested your time into it, but kindly do not create such PRs unless there is an existing issue that was triaged by the team.

We do triage usually once a week to make sure the tasks that we work on are aligned with the Helidon project direction. Right now, as we are nearing 4.0.0 release, unexpected PRs are making our life a bit more complicated.

The best approach would be if you could join our public slack channel (see https://helidon.io/#community), so we could discuss such things in advance.

Thanks once again for the work you do for Helidon!

@romain-grecourt romain-grecourt merged commit 835d429 into helidon-io:helidon-3.x Aug 15, 2023
12 checks passed
@Captain1653
Copy link
Contributor Author

@tomas-langer Thank you for the detailed explanation.

@Captain1653 Captain1653 deleted the use-text-blocks branch August 16, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants