4.x Associate tracer-level tags with Jaeger process level (instead of span level) #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
changed the title
tomas-langer
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8763
The basics of the PR are the same as in the 3.x PR #7027 except that this PR also adds a test (which involves adding a test in-memory span processor which the test can query.) I added the unit test before fixing the code and the test failed pre-fix, passed post-fix.
Because of how the Jaeger code sets up the
OpenTelemetryinstance, the PR also adds a non-public method toJaegerTracerBuilderallowing the caller to add span exporters programmatically so the test can add the in-memory collector.I also manually started up
jaeger-all-in-onelocally and then ran the new unit test. The Jaeger UI now properly shows the tracer-level tag at the process level (not the span level).Documentation
Bug fix; no doc impact.