Restore First to Witness HIP #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial review round
|
I don't want to squash the work here, and discussed with @BFGNeil to make an editorial pass in this gist It looks like a lot of changes, and it kind of is, but mainly aiming to clarify a few sections for readability. Should not change any of the intentions of the HIP, but please double-check and let me know if there is anything else I can do to help! |
|
@BFGNeil did you review what @samgutentag said above? Anything else to add before we merge and number this? |
|
@vincenzospaghetti @samgutentag updated, changes look great. |
- added a note about implementation for Helium Core Devs in ## Deployment Impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the randomisation of selected witnesses.