Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP 95: Self-Onboard Hotspots After Maker Exit #744

Merged
merged 10 commits into from
Aug 31, 2023
Merged

Conversation

shawaj
Copy link
Contributor

@shawaj shawaj commented Jul 15, 2023

This HIP proposes a mechanism to improve the onboarding experience for hotspot users whose makers have left the network either voluntarily or through bankruptcy. Currently, if a maker leaves the network and has run out of onboarding credits, the users are left with only cumbersome or risky ways to onboard their devices to the network. This proposal seeks to change this in a way that lets users onboard their devices in a self-service manner if their hotspot maker has left the ecosystem.

Rendered view: https://github.com/helium/HIP/blob/7e50570543a651f240af73864088a5ad05a56077/00xx-wallet-owner-pay-onboard.md

This HIP proposes a mechanism to improve the onboarding experience for hotspot users whose makers have left the network either voluntarily or through bankruptcy. Currently, if a maker leaves the network and has run out of onboarding credits, the users are left with only cumbersome or risky ways to onboard their devices to the network. This proposal seeks to change this in a way that lets users onboard their devices in a self-service manner if their hotspot maker has left the ecosystem.
@shawaj shawaj marked this pull request as ready for review July 15, 2023 15:33
shawaj and others added 3 commits July 15, 2023 17:29
Change to MCC instead of foundation

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Add HIP PR

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
@shawaj shawaj changed the title Allow a wallet user to onboard with own funds if maker leaves network Process for onboarding fee payment after maker exit Aug 9, 2023
@Sophi
Copy link
Contributor

Sophi commented Aug 10, 2023

@shawaj
HIP needs one more Stakeholder and a Drawback
Stakeholder
Hotspot App Developers/Creators - who need to implement changes in the App for the option to pay from the customers wallet.
Drawback:
The Makers don't implement the changes required in their App and the HIP process this HIP is designed to resolve is not implemented.

@shawaj
Copy link
Contributor Author

shawaj commented Aug 10, 2023

Added now @Sophi 👍

Did some minor edits for clarifications, also added in MOBILE onboards/assertions post HIP-89.
There are now 3 drawbacks but final sentence mentions "both", needs an edit.
Also added in comment that the Helium Wallet App can Assert IOT/MOBILE locations from the Owner Wallet already.
Moved the who will implement to the Deployment Impact section.
@shawaj
Copy link
Contributor Author

shawaj commented Aug 17, 2023

@waveform06 any further thoughts on this?

@waveform06
Copy link
Collaborator

I did this but dont see it merged
https://github.com/shawaj/HIP/pull/2/files

@shawaj
Copy link
Contributor Author

shawaj commented Aug 18, 2023

@waveform06 sorry, totally missed that PR!

Update 00xx-wallet-owner-pay-onboard.md
@shawaj
Copy link
Contributor Author

shawaj commented Aug 19, 2023

Merged now @waveform06 🙏

@abhay
Copy link
Contributor

abhay commented Aug 28, 2023

I think this needs to be merged, channel created, etc, right, @waveform06 @shawaj?

I know a big pending item is what the engineering impact here is and who's going to be working on it but I'm sure we can be resolved through discussion and prior to a vote.

@shawaj
Copy link
Contributor Author

shawaj commented Aug 29, 2023

Yes, that's correct @abhay

@hiptron hiptron changed the title Process for onboarding fee payment after maker exit HIP 95: Self-Onboard Hotspots After Maker Exit Aug 31, 2023
@hiptron hiptron merged commit b1a33db into helium:main Aug 31, 2023
@shawaj shawaj deleted the patch-6 branch August 31, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants