Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HIP proposal - Finetune HIP17 parameters to tackle density #830

Merged

Conversation

riobah
Copy link
Contributor

@riobah riobah commented Dec 12, 2023

Finetune HIP17 parameters to tackle density

@waveform06
Copy link
Collaborator

There is a rendered view of this HIP with the attached images here
https://heliumgeek.com/0000-finetune-hip17-parameters-to-tackle-density.pdf

@waveform06 waveform06 added the technical Technical HIPs label Dec 13, 2023
@gradoj
Copy link
Contributor

gradoj commented Dec 14, 2023

The proposed solution makes the scaling number increase in many of the dense examples. Is this not opposite of the hips stated objective to "focusing on addressing the increased hotspot density in urban areas"? Would reducing hip15 redundancy variable not give desired results of less rewards overall to dense areas?

@riobah
Copy link
Contributor Author

riobah commented Dec 14, 2023

As shown in the appendix images and on the live map, urban areas are generally scaled more significantly in this proposal. Regarding certain urban hexes like some in NYC receiving a higher scale, this is due to the relaxed scaling at the resolution-4 level, which previously caused sharp boundary edges. For example, hex 8a2a10728287fff was primarily scaled at the res-4 level.

In HIP15, the redundancy variable, N, predominantly scales witness rewards (when w > N). Since most beacons are fully witnessed, reducing N is unlikely to decrease total reward units, as shown in the chart.
HIP15 reward distribution

@gradoj
Copy link
Contributor

gradoj commented Dec 14, 2023

Yes, removing r4 makes some dense areas worse. It is opposite of the stated goal of the hip so doesn't seem acceptable.

I must be thinking about it wrong cause reducing redundancy from 4 to 1 would reduce the earnings across the board in dense areas - which aligns with the stated goal of the hip more than the proposed hip17 tweak

@hiptron hiptron merged commit 3d4710e into helium:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Technical HIPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants