Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guide for Setting Up Local Server to Contribute to Documentation #1832

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ekemini004
Copy link

@Ekemini004 Ekemini004 commented Feb 27, 2024

Hiii, I was pretty confused initially on how to contribute to the docs since there were no guides. If it was confusing for me, it might be for someone else too (maybe future contributors), so I thought why not create this guide.

please feel free to communicate your feedback, I would gladly appreciate it , thanks !

@jthiller jthiller added the Solana Scribes 2024 Issues and PRs related to the Hackathon - solanascribes.com label Feb 28, 2024
@Ekemini004
Copy link
Author

Hii @jthiller would appreciate your review feedback 😊, Thanks !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rework this guide to live on https://docs.helium.com/faq/docs-installation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay let me do that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

CONTRIBUTING.md Outdated
Comment on lines 41 to 45





Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Need to run prettier to clean keep consistent formatting.


```bash
# Clone the repository
git clone https://github.com/your-username/project-repository.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be docs repo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Comment on lines 34 to 35
git clone https://github.com/your-username/project-repository-name.git
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a generic guide? Needs to clone docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will effect the changes shortly, thanks for the feedback

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jthiller would preciate your review feedback 😊

@Ekemini004
Copy link
Author

Ekemini004 commented Feb 29, 2024

@jthiller effected all the review changed you suggested! But the installation guide link on readme.md is supposed to be the same with the new file I created , I’m guessing cos helium has its own domain hosted on GitHub pages , I can’t change that

I’m using a relative link path, the official documentation uses an absolute link path

so far that’s the only conflicting issue

the links on that page don’t match , any guides on how I could make them make them match ?
?

@Ekemini004
Copy link
Author

@jthiller would really appreciate your review feedback

@jthiller
Copy link
Contributor

jthiller commented Mar 7, 2024

Thank you for submitting updates to the Helium Docs as part of the Solana Scribes Hackathon! Please follow the instructions in this form so we may begin issuing awards.

https://forms.gle/z4ovMHYDo7pzy8TN6



Please complete this form by March 15, 2024. (Approximately 1 week from today). We had SO MANY great submissions and we’re eager to distribute the awards to all of the contributors.

@jthiller
Copy link
Contributor

jthiller commented Mar 7, 2024

Apologies, something happened to the Google forms link. This one should work: https://forms.gle/z4ovMHYDo7pzy8TN6

@Ekemini004
Copy link
Author

Flamingo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solana Scribes 2024 Issues and PRs related to the Hackathon - solanascribes.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants