Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix badmatch errors when acs calls bba_input #17

Merged
merged 2 commits into from
Jun 29, 2018
Merged

fix badmatch errors when acs calls bba_input #17

merged 2 commits into from
Jun 29, 2018

Conversation

vihu
Copy link
Member

@vihu vihu commented Jun 29, 2018

Adds case clauses for handling bba:input when the state of the bba is already set to done.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 185

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 91.365%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hbbft_acs.erl 4 6 66.67%
Totals Coverage Status
Change from base Build 181: -0.2%
Covered Lines: 328
Relevant Lines: 359

💛 - Coveralls

@Vagabond
Copy link
Contributor

It's interesting dialyzer didn't catch this.

@Vagabond Vagabond merged commit addc137 into master Jun 29, 2018
@Vagabond Vagabond deleted the rg/bba-bug branch June 29, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants