Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP on implementing the TERM message #22

Merged
merged 4 commits into from
Oct 4, 2018
Merged

WIP on implementing the TERM message #22

merged 4 commits into from
Oct 4, 2018

Conversation

Vagabond
Copy link
Contributor

@Vagabond Vagabond commented Sep 4, 2018

This is a WIP, but I don't want to forget about it so here it is.

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 235

  • 46 of 53 (86.79%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 86.893%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hbbft_bba.erl 46 53 86.79%
Totals Coverage Status
Change from base Build 227: 1.5%
Covered Lines: 358
Relevant Lines: 412
💛 - Coveralls

vihu
vihu reviewed Sep 21, 2018
View reviewed changes
Copy link
Member

@vihu vihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, rest of the changes here seem to make sense I think.

src/hbbft_bba.erl
Old = maps:get(Id, Witness, 0),
New = add(Value, Old),
case Old /= New of
true when New == 3, AllowUnion == false ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand the difference here if both the true clauses return the same Witness. Perhaps I'm missing something...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guards are different, I suppose we could combine them but they represent distinct cases.

@vihu vihu merged commit fe8fc42 into master Oct 4, 2018
@vihu vihu deleted the adt/term-message branch October 4, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vihu vihu vihu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vagabond @coveralls @vihu