Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Make assert location transaction page look nice #136

Merged
merged 5 commits into from
Jan 9, 2021

Conversation

danielcolinjames
Copy link
Contributor

@danielcolinjames danielcolinjames commented Jan 5, 2021

Fixes #121

Adds the following improvements to the assert location transaction view:

  • has its own file now (instead of using the fallback JSON dump)
  • shows a map with a marker for the new asserted location
  • shows fees in correct denomination
  • shows who paid the staking fee (staking server or hotspot owner)
  • shows location nicely formatted, e.g.: "City, State, Country" as long as the hotspot's current lat/lng matches the one asserted in the transaction

@madninja for the last item above ^, would it be easy / feasible to add the geocode data to the assert location transaction response? Right now I have the page doing an extra client-side fetch for the hotspot data, and using the geocode given given for the hotspot to display City, State, Country names so you don't have to zoom out on the map to know where the assert happened. But obviously that method won't work when the hotspot's current location is different from the one that was asserted in that transaction.

Also added a color tag for add_gateway_v1 and assert_location_v1 transactions:
Screen Shot 2021-01-06 at 3 13 20 PM

You can see them here:
http://helium-explorer-pr-136.herokuapp.com/accounts/14fzfjFcHpDR1rTH8BNPvSi5dKBbgxaDnmsVPbCjuq9ENjpZbxh

Screenshots:

This page before:

Screen Shot 2021-01-06 at 2 49 57 PM
https://explorer.helium.com/txns/rzZc7rLqqGlMwoHPquu7RQ3fSnCuZlVI85wOJvNrQTo

This page in this PR:

Screen Shot 2021-01-06 at 2 49 38 PM
https://helium-explorer-pr-136.herokuapp.com/txns/rzZc7rLqqGlMwoHPquu7RQ3fSnCuZlVI85wOJvNrQTo

@allenan allenan temporarily deployed to helium-explorer-pr-136 January 5, 2021 04:34 Inactive
@danielcolinjames danielcolinjames changed the title WIP: Add basic assert location transaction page details WIP: Make assert location transaction page look nice Jan 5, 2021
@allenan allenan temporarily deployed to helium-explorer-pr-136 January 6, 2021 22:43 Inactive
@danielcolinjames danielcolinjames changed the title WIP: Make assert location transaction page look nice Make assert location transaction page look nice Jan 6, 2021
@allenan allenan temporarily deployed to helium-explorer-pr-136 January 6, 2021 23:10 Inactive
@danielcolinjames danielcolinjames marked this pull request as ready for review January 6, 2021 23:11
@allenan allenan temporarily deployed to helium-explorer-pr-136 January 6, 2021 23:52 Inactive
Copy link
Member

@allenan allenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, certainly a big improvement over the current state. I left comments in the http issue, but think we should add geocode to the transaction response rather than querying a general purpose api

@madninja
Copy link
Member

madninja commented Jan 8, 2021

this looks good, certainly a big improvement over the current state. I left comments in the http issue, but think we should add geocode to the transaction response rather than querying a general purpose api

No other data is pushed into specific transactions today, why would we break this now?

@allenan allenan temporarily deployed to helium-explorer-pr-136 January 8, 2021 23:46 Inactive
@danielcolinjames danielcolinjames merged commit 571630a into master Jan 9, 2021
@danielcolinjames danielcolinjames deleted the dcj/assert-location-display branch January 9, 2021 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make assert location transaction detail page look nicer
3 participants