This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Make assert location transaction page look nice #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Adds the following improvements to the assert location transaction view:
@madninja for the last item above ^, would it be easy / feasible to add the geocode data to the assert location transaction response? Right now I have the page doing an extra client-side fetch for the hotspot data, and using the
geocode
given given for the hotspot to display City, State, Country names so you don't have to zoom out on the map to know where the assert happened. But obviously that method won't work when the hotspot's current location is different from the one that was asserted in that transaction.Also added a color tag for
add_gateway_v1
andassert_location_v1
transactions:You can see them here:
http://helium-explorer-pr-136.herokuapp.com/accounts/14fzfjFcHpDR1rTH8BNPvSi5dKBbgxaDnmsVPbCjuq9ENjpZbxh
Screenshots:
This page before:
https://explorer.helium.com/txns/rzZc7rLqqGlMwoHPquu7RQ3fSnCuZlVI85wOJvNrQTo
This page in this PR:
https://helium-explorer-pr-136.herokuapp.com/txns/rzZc7rLqqGlMwoHPquu7RQ3fSnCuZlVI85wOJvNrQTo