Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable web onboarding. #783

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Enable web onboarding. #783

merged 1 commit into from
Jul 15, 2021

Conversation

matthewcarlreetz
Copy link
Contributor

@matthewcarlreetz matthewcarlreetz commented Jul 14, 2021

Closes #766

Enables WEB onboard type
Opens QR/WEB onboarding to everyone by removing qrEnabled feature flag

@matthewcarlreetz matthewcarlreetz marked this pull request as ready for review July 14, 2021 18:05
navigation,
])

const handleBarCodeScanned = useDebouncedCallback(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use-debounce seems nice, I have a place where I should consider using that in explorer

>
{subtitle}
</Text>
{linkToMaker}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth breaking things like this out into proper components since that's really all it is

Copy link
Member

@allenan allenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good 👍

@matthewcarlreetz matthewcarlreetz merged commit 97c409e into main Jul 15, 2021
@matthewcarlreetz matthewcarlreetz deleted the feature/766_web-onboarding branch July 15, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Link/Web Onboarding
2 participants