-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rx_delay
from Console to LoRaWAN config
#548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpezely
commented
Dec 14, 2021
•
edited
Loading
edited
- This should resolve issue Add RxDelay to LoRaWAN Configs #531
- This will assist devices in regions where internet backbone latency contributes to timing issues; e.g., AU->US
- For this feature to be fully function, it is blocked by Console PR#952
macpie
reviewed
Dec 17, 2021
CI tests failed due to XOR Filter which wasn't touched for this PR, but all tests pass when running locally on Linux (Xubuntu 20.04.3) via both:
|
macpie
approved these changes
Dec 17, 2021
This was referenced Dec 18, 2021
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.