Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to non-existent soft-wrap.wrap_at_text_width option in docs #6803

Closed
augustebaum opened this issue Apr 18, 2023 · 3 comments
Closed
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@augustebaum
Copy link

The docs for the editor.text-width option (https://docs.helix-editor.com/configuration.html?highlight=editor#editor-section) refer to the other option: soft-wrap.wrap_at_text_width. It should be soft-wrap.wrap-at-text-width. Could there be a way to dynamically link to the option itself to avoid desynchronization?

@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-documentation Area: Documentation improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Apr 18, 2023
@Mordeaux
Copy link
Contributor

I'm new around here, so I'm not sure what the process is, but I think this can be closed now, correct?

@the-mikedavis
Copy link
Member

Yep this is fixed now. I didn't notice when merging but the PR wasn't linked to the issue so it didn't close it automatically. For future reference, you can use a few keywords to automatically link PRs to issues so they're closed when the PR is merged: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue (I'm surprised "solves" isn't in that list actually 🤔)

the-mikedavis added a commit that referenced this issue Apr 23, 2023
wrap_at_text_width -> wrap-at-text-width

Connects #6803
@Mordeaux
Copy link
Contributor

Mordeaux commented May 2, 2023

@the-mikedavis ah thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

No branches or pull requests

3 participants