-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added workspace_symbol_picker #1041
Conversation
The start of an item gets truncated if it's too long, which hides the name of symbol (due to #951): |
I see two potential solutions:
But this does not look so good without truncation:
What solution would be preferred? Or does anybody have any other ideas. |
Let's add a field helix/helix-term/src/ui/picker.rs Line 569 in cf831b1
This way you can initialize it like this: let picker = Picker::new(...);
picker.truncate_start = true;
compositor.push(Box::new(picker)) By the way, what theme are you using? It looks like it's missing the picker border color, that's why it's blue. |
We probably want to set this flag on the other symbol picker too. I'm also wondering whether the key should be |
I and the other symbol picker uses FilePicker at the moment. Should i also add the truncate_start field to FilePicker? |
You can keep |
FilePicker is used at the moment for all the pickers since it also gives the file preview to the left. So I think it is FilePicker that should get the change to have a truncate_left option. |
Ah sorry, I confused it with the |
15258f4
to
32aa748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with rust-analyzer. There's also a merge conflict btw.
ce17ae0
to
a80f205
Compare
Fixed typo and merge conflict |
Thanks! 🎉 |
closes #1009
Uses
space
>t
to open a workspace wide symbol picker.