Buffer complete #1134
Merged
Buffer complete #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
force-pushed
the
buffer-complete
branch
2 times, most recently
from
48949ef
to
99badb5
Compare
cole-h
commented
Nov 20, 2021
archseer
requested changes
Nov 21, 2021
pickfire
reviewed
Dec 11, 2021
pickfire
reviewed
Dec 11, 2021
|
Thanks for all the feedback -- I'll likely get around to this in this upcoming weekend, but I've got finals coming up, so I won't have much time during the week. 🙏 I promise I haven't forgotten about this! |
Closed
In order to implement this completer, the completion function needs to be able to access the compositor's context (to allow it to get the list of buffers currently open in the context's editor).
archseer
force-pushed
the
buffer-complete
branch
from
70328e4
to
3df2a30
Compare
|
Thanks for finishing this up! 🙇 I was really expecting to get back to this, but... after finals and work, I just wanted to chill and play the new FFXIV expansion (and then work and school started back up and now consume most of my free time). Sorry for the lack of communication and dropping the ball, and thanks again for pushing this across the finish line ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1043.