Convert Windows style path separator in completers to Unix style #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its now confirmed this fixes the issue. |
pickfire
reviewed
Dec 29, 2021
Comment on lines
+334
to
+336
| let path = if cfg!(windows) && is_dir { | ||
| // Convert Windows style path separator to Unix style | ||
| path.to_str().unwrap().replace("\\", "/") |
There was a problem hiding this comment.
Why only do it if it is a directory?
There was a problem hiding this comment.
Because only directories end with a path separator
for example:
file: file.ext
directory: directory\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of shellwords included support for escaping, which breaks windows style paths in the prompt.
This change converts backslashes to slashes for directories if helix is on windows.
According to the video in the issue tracker, unix style paths work fine there too.
I couldnt test this.
Issue #1380