Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds syntax highlighting for the interactive rebase TODO file:
with highlighting appropriate for the long and short versions of commands (e.g. "fixup" and "f"), and injections for shell with the
exec
command.And the cherry on top: injections for commit message highlighting when you're editing commit messages in a rebase:
I was interested in including this on #1338, but I couldn't get the injections to work.
It turns out injections seem to not work when the node being injected has an underscore in its name (e.g.(edit: now I can't reproduce that behavior and it works even with the underscore 🤔)rebase_command
instead ofrebasecommand
). I suspect that there's a rogue regex in the tree-sitter code that tries to ignore injections on unnamed nodes (start with an underscore) that's mistakenly checking for any underscore at all. (edit: meant to say that I think this is a bug upstream in tree-sitter, I'll investigate 🕵️)These captures are a little arbitrary, I'm open to suggestions on all of them.