New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme): fix rose_pine/rose_pine_dawn themes' popup bg color #1606

Merged

archseer merged 1 commit into helix-editor:master from chunghha:popup_fix

Jan 31, 2022

Contributor

chunghha commented Jan 31, 2022

To fix the 2 rose_pine themes' popup bg color as

Member

archseer commented Jan 31, 2022

Based on neovim theme, it seems the popup background should be surface https://github.com/rose-pine/neovim/blob/main/lua/rose-pine/theme.lua#L9 with subtle as the fg (https://github.com/rose-pine/neovim/blob/main/lua/rose-pine/theme.lua#L66).

For selected line, overlay as the bg, text as the fg: https://github.com/rose-pine/neovim/blob/main/lua/rose-pine/theme.lua#L68

Contributor Author

chunghha commented Jan 31, 2022

To me that bg color is too subtle

so can't see text until selected.

Perhaps problem is that setting fg for ui.popup seems no effect now.

Member

archseer commented Jan 31, 2022

You need to style ui.menu/ui.menu.selected for that

Contributor Author

chunghha commented Jan 31, 2022

I will update the PR with this.


          chore(theme): fix rose_pine/rose_pine_dawn themes' popup bg color

423fc95

chunghha force-pushed the popup_fix branch from 2e486be to 423fc95 Compare

January 31, 2022 03:50

archseer merged commit 4c996f4 into helix-editor:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet