Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename paragraph motion commands from move to goto #2226

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

the-mikedavis
Copy link
Member

As mentioned on the matrix. What do you think @pickfire, should the commands be renamed so it's goto_next_paragraph instead? That would line up with the other commands in this section in the docs

@pickfire
Copy link
Contributor

pickfire commented Apr 23, 2022

As mentioned on the matrix. What do you think @pickfire, should the commands be renamed so it's goto_next_paragraph instead? That would line up with the other commands in this section in the docs

I don't recall that but I don't mind the change, seemed the same to me, I don't have any preference over the function naming, both seemed fine for me.

@the-mikedavis
Copy link
Member Author

I should really link to Matrix discussions huh 😅

The thread is a bit spread out: https://matrix.to/#/!zMuVRxoqjyxyjSEBXc:matrix.org/$uiJVup9NrSYS7uQCKgPTb3iZSI8Xz5iieEM8IHOYZ9s?via=matrix.org&via=mozilla.org&via=tchncs.de

the tl;dr is that @n0s4 found that you can't map to the goto_next_paragraph commands in a keymap. It's just that the commands are documented under the wrong names.

I would actually prefer it be "goto" instead of "move". IMO "goto" makes sense if the selection jumps and "move" makes sense if you mostly intend on moving the cursor and the selection happens to go with it. I'm not sure that's a rigorous definition though 🤔

I'll switch this PR to rename the commands.

@the-mikedavis the-mikedavis changed the title Fix command name for next/prev paragraph motion Rename paragraph motion commands to "goto" Apr 23, 2022
@the-mikedavis the-mikedavis changed the title Rename paragraph motion commands to "goto" Rename paragraph motion commands from move to goto Apr 23, 2022
@archseer archseer merged commit 3f2bd77 into helix-editor:master Apr 24, 2022
@the-mikedavis the-mikedavis deleted the md-paragraph-docs-fix branch April 24, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants