Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic verilog support #2552

Merged
merged 1 commit into from
May 24, 2022

Conversation

andreytkachenko
Copy link
Contributor

Verilog files support

  • syntax highlighting
  • language server svlangserver
  • some textobjects

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the highlights just need to be aligned with the scopes we use: https://docs.helix-editor.com/themes.html#syntax-highlighting

runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/verilog/injections.scm Outdated Show resolved Hide resolved
@the-mikedavis
Copy link
Member

It looks like this will conflict with vlang: #2526

I'm not sure how we should handle a conflict like this. I suppose it'll be up to anyone using either to set up

# ~/.config/helix/languages.toml
use-grammars = { except = [ "v" ] }
# or
use-grammars = { except = [ "verilog" ] }

But I'm not sure which one should win being default 🙃

languages.toml Outdated Show resolved Hide resolved
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this!

@the-mikedavis the-mikedavis merged commit 67fe160 into helix-editor:master May 24, 2022
@andreytkachenko andreytkachenko deleted the verilog-support branch May 25, 2022 08:07
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants