Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stickiness configurable #4164

Closed
wants to merge 1 commit into from
Closed

Make stickiness configurable #4164

wants to merge 1 commit into from

Conversation

bbodi
Copy link
Contributor

@bbodi bbodi commented Oct 9, 2022

Fixes #1487 partially.

Allows config such as

[keys.normal.W]
sticky = true
I   = "vsplit"
E   = "hsplit"
...

@poliorcetics
Copy link
Contributor

This probably interacts with #3958 to fully complete #1487

@bbodi
Copy link
Contributor Author

bbodi commented Oct 10, 2022

This probably interacts with #3958 to fully complete #1487

Nice, unfortunately I haven't noticed it when I started my version.
As I can see it would be easier to extend #3958 with a simple

"label" => label = map.next_value::<&str>()?,
"sticky" => sticky= map.next_value::<bool>()?, // Add this

and then set the is_sticky field later accordingly.

So this one can be closed.

@kirawi kirawi closed this Oct 15, 2022
@bbodi bbodi mentioned this pull request Nov 10, 2022
Open
@gibbz00 gibbz00 mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set command list's name and sticky bit in a config
3 participants
@bbodi @poliorcetics @kirawi