Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufferline mouse action #5335

Closed
wants to merge 1 commit into from

Conversation

hunterliao29
Copy link
Contributor

@gibbz00
Copy link
Contributor

gibbz00 commented Dec 29, 2022

Maybe not the best to present two features in the PR but I'm guilty of it myself 😅

Anyhow, could the buffer-nth operations be incorporated into the default buffer-next and bugger-prev? Whereby 1 is the default unless a number is specified before the motion. Similar to how one can do 2w.

@hunterliao29
Copy link
Contributor Author

Anyhow, could the buffer-nth operations be incorporated into the default buffer-next and bugger-prev? Whereby 1 is the default unless a number is specified before the motion. Similar to how one can do 2w.

I'm not sure if I understanding this correctly. Is this about 1 based index, where :buffer-nth 1 should go to the first buffer?

@gibbz00
Copy link
Contributor

gibbz00 commented Dec 29, 2022

No, meaning that if I do 3 buffer_next i jump to the next buffer 3 times.

Naturally, 1buffer_next is then same as buffer_next.

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 29, 2022
@hunterliao29
Copy link
Contributor Author

What should be the behavior of multiple buffer-nth 0s?

@gibbz00
Copy link
Contributor

gibbz00 commented Dec 29, 2022

0buffer_next nothing?

@hunterliao29
Copy link
Contributor Author

:buffer-nth 0 will switch to the first open buffer, :buffer-nth 2 will switch to the second if there is one and so on. It does not consider their current position like buffer_next. I am not sure if there is a use case for repeating it.

@AddictArts
Copy link

AddictArts commented May 5, 2023

I'd like to see this feature happen, but seems to be stuck here. @hunterliao29 I think you might be missing what @gibbz00 is really asking. I think from reading, helix has a buffer_next code path; therefore, your buffer_nth is really duplicating in a sense what it does. The desire looks like just improving the existing buffer_next instead of adding yet another way to move between buffers. Maybe I have that wrong, but looking at code it does seem like one buffer motion code path could do both?

Apologies if I am way wrong or even slightly wrong, which happens.

@pascalkuthe
Copy link
Member

Closing this as its quite stale.The bufferline and mouse support are also not a priority. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants