Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to rotate view backward #5356

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

mejo13
Copy link
Contributor

@mejo13 mejo13 commented Jan 1, 2023

Adds command 'rotate_view_backward' and changes 'rotate_view' to 'rotate_view_forward' to stay consistent.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. R-breaking-change This PR is a breaking change for some behavior labels Jan 2, 2023
@the-mikedavis
Copy link
Member

Is there a use-case for this command or is it just to be symmetric with the current rotate_view?

@mejo13
Copy link
Contributor Author

mejo13 commented Jan 16, 2023

Using less key strokes when switching between 3+ views. In hindsight this doesn't have to be a breaking change though. Calling it rotate_view_reverse and leave rotate_view as is would be acceptable maybe?

@the-mikedavis
Copy link
Member

Ah yeah I like that, let's call it rotate_view_reverse 👍

@the-mikedavis the-mikedavis removed the R-breaking-change This PR is a breaking change for some behavior label Jan 17, 2023
@the-mikedavis the-mikedavis changed the title Add cmd to rotate view backward Add command to rotate view backward Jan 17, 2023
@the-mikedavis the-mikedavis merged commit e7e47fd into helix-editor:master Jan 17, 2023
@mejo13 mejo13 deleted the rotate_view_backward branch January 21, 2023 06:46
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants