Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statusline element 'file-indexer' #5491

Closed
wants to merge 5 commits into from

Conversation

mejo13
Copy link
Contributor

@mejo13 mejo13 commented Jan 10, 2023

Shows number of open files and index of the one currently viewed.

Shows number of open files and index of the one currently viewed.
@CBenoit CBenoit added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 13, 2023
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think you need to update the documentation as well:

The following statusline elements can be configured:

@archseer
Copy link
Member

Hmm I think we could come up with a better name for it. Indexer sounds like a background service that indexes files

@mejo13
Copy link
Contributor Author

mejo13 commented Jan 14, 2023

Maybe file_counter would be more fitting or do you have an idea?

@the-mikedavis
Copy link
Member

FileNumber or FileCount would make sense to me. I think we should avoid naming things with agent nouns (indexer, counter) except where there's a lot of precedent for it (picker, receiver, server)

@mejo13
Copy link
Contributor Author

mejo13 commented Jan 14, 2023

I'd go with FileCount then, if that's ok!?

@mejo13
Copy link
Contributor Author

mejo13 commented Jan 16, 2023

What is the preferred way to do this? Change the existing pr, which would make the discussion about the name kinda pointless, or make a new one? I'm pretty new to git and github so i'm realy not sure.

@CBenoit
Copy link
Member

CBenoit commented Jan 16, 2023

What is the preferred way to do this? Change the existing pr, which would make the discussion about the name kinda pointless, or make a new one? I'm pretty new to git and github so i'm realy not sure.

Feel free to commit and push additional commits to apply the suggestions. Unless you push force, original commit history will stay available from this PR. That being said, it’s generally okay to just push force if you wish to get the commits merged as is. If history is not "clean", maintainers will just squash and merge as necessary, so feel free to proceed as you prefer in this case. 🙂

Destructure the argument of a closure instead of dereferencing later.
@gibbz00 gibbz00 mentioned this pull request Feb 22, 2023
5 tasks
@mejo13
Copy link
Contributor Author

mejo13 commented Mar 31, 2023

Hey, I was wondering if I have to change something else, request a review or is this better suited as a plugin once the system is in place maybe?

@pascalkuthe
Copy link
Member

I am going to close this one out as stale since the statusline has been refactored. I think this one is a bit niche and better suited for a plugin. Sorry we didn't give you that feedback sooner and thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants