-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statusline element 'file-indexer' #5491
Conversation
Shows number of open files and index of the one currently viewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think you need to update the documentation as well:
helix/book/src/configuration.md
Line 93 in 051cd78
The following statusline elements can be configured: |
Hmm I think we could come up with a better name for it. Indexer sounds like a background service that indexes files |
Maybe file_counter would be more fitting or do you have an idea? |
FileNumber or FileCount would make sense to me. I think we should avoid naming things with agent nouns (indexer, counter) except where there's a lot of precedent for it (picker, receiver, server) |
I'd go with FileCount then, if that's ok!? |
What is the preferred way to do this? Change the existing pr, which would make the discussion about the name kinda pointless, or make a new one? I'm pretty new to git and github so i'm realy not sure. |
Feel free to commit and push additional commits to apply the suggestions. Unless you push force, original commit history will stay available from this PR. That being said, it’s generally okay to just push force if you wish to get the commits merged as is. If history is not "clean", maintainers will just squash and merge as necessary, so feel free to proceed as you prefer in this case. 🙂 |
Destructure the argument of a closure instead of dereferencing later.
Hey, I was wondering if I have to change something else, request a review or is this better suited as a plugin once the system is in place maybe? |
I am going to close this one out as stale since the statusline has been refactored. I think this one is a bit niche and better suited for a plugin. Sorry we didn't give you that feedback sooner and thank you for contributing! |
Shows number of open files and index of the one currently viewed.