Fix go locals query for var_spec identifiers #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Apr 16, 2023
the-mikedavis
added
the
A-language-support
pascalkuthe
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a tiny fix to the
var_speclocals query for Go. The existing query makes use of the "name" field, but when there are multiple variables in the same declaration, only the first gets captured. It's fine for us to not specify the field, because if a type or a value is provided, any identifier nodes within them either have a different name such as type_identifier, or they're nested within a further sub-expression. Below are some screenshots showing the change, and the edge cases that I considered, which seem to be handled correctly with the updated query:bis not recognized as a local):bis recognized as a local):cis not recognized as local):cis not recognized as local):