flip symbol range in LSP goto commands #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-enhancement
the-mikedavis
approved these changes
Apr 17, 2023
|
(Prior discussion was in #6500 (comment)) |
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5986 the various LSP based goto commands were changed to select the entire symbol range instead of just placing the cursor at the symbol start to bring them in line with other pickers like diagnostics/symbol picker. However, in the symbol picker and the diagnostic picker the range sent by the LSP is flipped, so the cursor is placed at the start of the range (the start of the function instead of the end for example). This is very useful when jumping to the definition of large symbols like modules/classes or function.
This PR adjusts the LSP goto commands to match the other LSP pickers in this regard. This behavior is closer to the old behaviour (which paced the cursor at the start of the symbol too but just didn't add the remaining selection) and I therefore added it to the bugfix release sice this feels like a (very minor) usability regression to me.