produce error when grammar build fails #6795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
E-easy
pascalkuthe
force-pushed
the
grammer_build_error
branch
from
6ab3278
to
a9ad33e
Compare
pascalkuthe
force-pushed
the
grammer_build_error
branch
2 times, most recently
from
a70774e
to
29e6f7c
Compare
pascalkuthe
force-pushed
the
grammer_build_error
branch
from
29e6f7c
to
5cc7c32
Compare
|
With the other PR merged, can you rebase this one? |
|
Will do that tomorrow morning. The timing was a bit unfortunate just turned off my PC for today sorry about that I had the other branch merged into this branch to be able to check that the build really passes CI, I guess I should have just made this a single PR |
pascalkuthe
force-pushed
the
grammer_build_error
branch
from
5cc7c32
to
26eeb88
Compare
|
(done) |
the-mikedavis
approved these changes
Apr 18, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
* produce error when grammar build fails * print which grammar build failed
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
* produce error when grammar build fails * print which grammar build failed
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* produce error when grammar build fails * print which grammar build failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #6792 (comment).
Currently, grammar builds fail without actually aborting the build (even tough that seems to be the intention since we explicitly call
except) because we only print to stdout when the build fails but don't actually return an error. This makes diagnosing and fixing build failures harder. This PR fixes that by simply callingbail!instead ofprintln!. As described here #6792 (comment) this slightly changes the formatting of the error message. I have therefore opted to remove the indentation from the failure message as that now looks a bit out of place