Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Response #4

Closed
sebsebmc opened this issue Mar 2, 2024 · 9 comments
Closed

Error Response #4

sebsebmc opened this issue Mar 2, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@sebsebmc
Copy link

sebsebmc commented Mar 2, 2024

Im currently git-scraping the API and occasionally getting error responses for /api/801/status:

{"errors":{"detail":"Not Found"}}

If you are caching results it would be good to attempt to drop these error responses, serve either old data and attempt to fetch new data (reasonable rate limits considered).

dealloc added a commit that referenced this issue Mar 2, 2024
@dealloc
Copy link
Member

dealloc commented Mar 3, 2024

@sebsebmc I've made some changes to the hosting it runs on, are you still running into problems regarding container startup?

@sebsebmc
Copy link
Author

sebsebmc commented Mar 3, 2024

I'll need to check the history to see how often it erred but I'm definitely get rate limit responses.

@sebsebmc
Copy link
Author

sebsebmc commented Mar 3, 2024

You can see the history of the helldivers.json file here https://github.com/sebsebmc/helldivers-history

@dealloc
Copy link
Member

dealloc commented Mar 3, 2024

Odd, but if more people are using Github IP's to scrap the API you might be hitting those rate limits.

My question are more regarding if you got 404 errors (due to the application restarting and not being ready yet)

@sebsebmc
Copy link
Author

sebsebmc commented Mar 3, 2024

Going back 9 hours it looks mostly to be rate limit errors rather than not found. Haven't seen the error show up in a quick skim.

@dealloc
Copy link
Member

dealloc commented Mar 3, 2024

I can see about increasing the rate limit now that the API has a bit more breathing room in resources, but that's not guaranteed to fix all those problems

dealloc added a commit that referenced this issue Mar 3, 2024
@dealloc
Copy link
Member

dealloc commented Mar 3, 2024

@sebsebmc I've increased rate limit (10x), let me know if the problem persists for you

@sebsebmc
Copy link
Author

sebsebmc commented Mar 3, 2024

Yeah, I need to setup analysis of the logging but I do think it has helped, no rate limit issues in the last hour or so

@dealloc
Copy link
Member

dealloc commented Mar 3, 2024

Awesome, I'll be closing this then.
If you run into any trouble along the way in the future feel free to open a new ticket

@dealloc dealloc closed this as completed Mar 3, 2024
@dealloc dealloc added the bug Something isn't working label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants