Make xortool compatible with Python 3 (and stay compatible with Python 2) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this tool helpful in malware analysis and I'm thinking about packaging it for Debian.
But Python 2.x is end of life in just a few years and many Linux distributions (at least Debian) are already working on phasing out Python-2-only applications. Accordingly I expect that it's not welcome to newly package Python-2-only applications (in any distro).
So I checked how much work it might be to make this tool Python-3-compatible. And to my surprise, it wasn't much work, even for someone who isn't too experienced in Python.
Tested with Python 3.5 and Python 2.7 from Debian Stable (Debian 9.5 Stretch as of now). Will later also test with Python 3.7 on Debian Unstable.