6 every deployment replaces the bridge certificate #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbyheart
requested changes
Jul 17, 2023
|
I've changed the Settings API in 34e04b9 ... so that only used scope/system combinations are documented which also makes it easier to introduce new scopes. |
pudkrong
force-pushed
the
6-every-deployment-replaces-the-bridge-certificate
branch
from
26b1db1 to
a43bdf5
Compare
|
New scope: export enum Scope {
...
NRFCLOUD_BRIDGE_CONFIG = 'nrfcloud/bridge'
...
} |
pudkrong
force-pushed
the
6-every-deployment-replaces-the-bridge-certificate
branch
from
a43bdf5 to
54bc3d6
Compare
coderbyheart
requested changes
Jul 18, 2023
Use the existing settings API instead and extract the reading of a map of files to a separate function
bridge/certificatesSSM.ts
Outdated
| if (parameterNamePrefix in parameters) { | ||
| const certificatesInSSM = parameters[parameterNamePrefix] | ||
| for (const key in certificates) { | ||
| if (typeof certificatesInSSM === 'object' && key in certificatesInSSM) { |
There was a problem hiding this comment.
Note: this is a hack, it does not match the type of parameters.
Use the existing settings API instead and extract the reading of a map of files to a separate function This also fixes the issue with the proposed implementation that goes around the settings API types
Previously the certificate map was not validated whether it is complete
coderbyheart
deleted the
6-every-deployment-replaces-the-bridge-certificate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development environment, the generated certificates are saved into
certificatesfolder and will be reused if they are existing. Therefore, there are no change in CDK.However, in deployment workflow, the
certificatesfolder never exists. So, the certificates are created every time and cause changes in CDK.In this PR, I have backup the certificates in SSM and restore them if exists.