Fix: update AccountInfo schema #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update missing properties in the schema: currentMonthCosts, name, serviceKeys
coderbyheart
requested changes
Sep 22, 2023
Co-authored-by: Markus Tacker <Markus.Tacker@NordicSemi.no>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278
The API response were not considered valid since the possible names in 'plan' did not include the name 'ENTERPRISE' in the validation. In addition the 'serviceID' in 'currentMonthCosts' did not include 'AGPS' in the validation.
'currentMonthCosts' and 'name' is not used in the code, and is removed from the validation.