fix: catch error if ssm extension is not ready #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change deals with the lock, nothing with SSM related? |
Lambda parameter store extension will be ready to read inside the handler. Calling it outside handler might not get the value.
pudkrong
force-pushed
the
fix-read-nrf-cloud-key-from-ssm
branch
from
38e5198 to
90b9544
Compare
Sorry, I will create a separated PR to fix lock. For the SSM cannot read nRF Cloud API Key, the root cause is that reading parameter from outside handler might be failed due to lambda parameter store is not ready yet. Therefore, I reverted the previous changes and commit the new fix. |
coderbyheart
requested changes
Jun 28, 2023
| websocketDeviceConnectionsTableName, | ||
| ) | ||
| const deviceShadowPromise = (async () => { | ||
| const deviceShadowPromise = once(async () => { |
There was a problem hiding this comment.
This effectively does the same thing as before. It ensures that deviceShadowPromise only exists once. It will stay in a rejected stated if parameters cannot be fetched.
There was a problem hiding this comment.
Ah, right. Now I see. It does fix the problem, because the lambda is invoked only in the handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda SSM extension might not be ready yet when we request. So, we need to handle properly otherwise it will crash lambda and error loop