Add LightControl message #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plasticchris
reviewed
Dec 1, 2016
|
|
||
| message LightControl { | ||
| enum Method { | ||
| POST = 0; |
There was a problem hiding this comment.
it might be better to let the body include the http headers, so this only needs the IP and the blob to send there
There was a problem hiding this comment.
@plasticchris do you mean generating the entire socket stream?
There was a problem hiding this comment.
we can reuse this message to post anything anywhere... good for botnets
zer0page
reviewed
Dec 1, 2016
| enum Method { | ||
| POST = 0; | ||
| } | ||
| required string url = 1; |
There was a problem hiding this comment.
#define HOST_LEN 32
#define PATH_LEN 64
FW has a limit on how long host and path can be. might be a good idea to cap them as an option.
|
I meant to have the server provide the IP and the entire http request,
headers and all. Then the method would be whatever is indicated in those
headers.
…On Wed, Nov 30, 2016, 5:16 PM Jackson Chen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In messeji/audio_commands.proto
<#138 (review)>:
> @@ -20,3 +20,12 @@ message Volume {
message VoiceControl {
required bool enable = 1;
}
+
+message LightControl {
+ enum Method {
+ POST = 0;
+ }
+ required string url = 1;
#define HOST_LEN 32
#define PATH_LEN 64
FW has a limit on how long host and path can be. might be a good idea to
cap them as an option.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHR0tA0xEh505xjQ8lnx3bsDe5W9S0I1ks5rDiADgaJpZM4LA4Wq>
.
|
|
@plasticchris does this work for you? |
plasticchris
approved these changes
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @plasticchris