Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-spatial mode broken #134

Open
probonopd opened this issue Oct 23, 2021 · 4 comments
Open

Non-spatial mode broken #134

probonopd opened this issue Oct 23, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@probonopd
Copy link
Member

Opens each folder in a new window even if Spatial model is off.
Can this be reproduced?
Which commit introduced this bug? Possible need to do git bisect.

@probonopd probonopd added the bug Something isn't working label Oct 23, 2021
@daniel-lemke
Copy link

This can be reproduced. I activated non-spatial mode and I still had new windows for each folder. It did change the window some so that I had navigation controls on the window, which those worked fine.

@probonopd
Copy link
Member Author

probonopd commented Nov 28, 2021

It had worked once. I think I must have broken it accidentally (and not noticed since I use Spatial).
We need to figure out which commit broke it by using git bisect...

@daniel-lemke
Copy link

daniel-lemke commented Nov 28, 2021 via email

@probonopd
Copy link
Member Author

I would not be entirely surprised if it started to break around 1c60345. Possibly we need to use some if (isSpatialMode()) {...}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants