Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add custom packages #165

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

crees
Copy link
Contributor

@crees crees commented Feb 27, 2021

Since drm-kmod is never going to match 12.2, we should just fix this now.

Any line starting with https in the package files is pulled separately.
They should be in reverse order of dependencies.

I've build drm-kmod for 12.2, but of course these could come from anywhere.

The logic for pulling pkgs from https is reusable and should work just fine with any location- I fully understand that you may not want it to pull from some untrusted and unknown site!

Since drm-kmod is never going to match 12.2, we should just fix this now.

Any line starting with https in the package files is pulled separately.
They should be in reverse order of dependencies.

I've build drm-kmod for 12.2, but of course these could come from anywhere.
@crees
Copy link
Contributor Author

crees commented Feb 27, 2021

Er, don't expect this to work with 12.1-release btw-- it'll probably build just fine, but it might end up crashing on use. This fix is for 12.2-- I understand it was the only blocker? You appear to have moved on anyway, so this would solve it.

@probonopd
Copy link
Member

Thank you very much @crees. As outlined in #1 (comment) I'd like to put this on hold until we find a way to produce packages on Cirrus CI.

@crees
Copy link
Contributor Author

crees commented Feb 27, 2021

I haven't run tested this one yet-- will let you know.

@probonopd
Copy link
Member

Certificate verification failed for /CN=api.cirrus-ci.com... why?

@crees
Copy link
Contributor Author

crees commented Mar 1, 2021

pkg appears to be fussy about https certificates it would appear. I've instead used fetch to download them to the cache dir and install them that way- this has the advantage that they don't need refetching.

This does give me the proper lovely looking desktop, but slim doesn't automatically log me in, I end up with slim asking me to log in. "liveuser" is pre-filled, so i only need to hit "Enter", but that doesn't seem right to me. Is that what sometimes happens? I don't see how this change would cause that.

@probonopd
Copy link
Member

Thanks @crees, is there any way to do this but not break 12.1 builds?
Possibly we need to make separate packages files for 12.1, 12.2, 13.0?

@crees
Copy link
Contributor Author

crees commented Mar 1, 2021

Sure, we can do this. I'll look at making a package for both.

These are trusted, as you can refer back to the github source

Cache these in the usual place

Currently supported for 12.1 and 12.2; they are built from
https://github.com/crees/drm-kmod-FreeBSD-12,
so the .cirrus.yml would need updating for further versions
@crees
Copy link
Contributor Author

crees commented Mar 3, 2021

We don't need to do for 13.0- drm-kmod from the packages will be fine. Let's see if the test works...

@probonopd
Copy link
Member

Fingers crossed!

@probonopd probonopd merged commit d8764a2 into helloSystem:experimental Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants