fix: Transpile node modules

nathanbuchar · nathanbuchar · commit 4f19db51b23b · 2019-01-23T17:05:15.000-08:00
Fixes #99
diff --git a/babel.config.js b/babel.config.js
@@ -10,8 +10,10 @@ module.exports = {
       useBuiltIns: 'usage',
     }],
   ],
+  ignore: [/[\/\\]core-js/],
   plugins: [
     '@babel/plugin-proposal-object-rest-spread',
     '@babel/plugin-proposal-class-properties',
+    '@babel/plugin-transform-modules-umd',
   ],
 };
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,6 +39,7 @@
     "@babel/core": "^7.1.6",
     "@babel/plugin-proposal-class-properties": "^7.1.0",
     "@babel/plugin-proposal-object-rest-spread": "^7.0.0",
+    "@babel/plugin-transform-modules-umd": "^7.2.0",
     "@babel/preset-env": "^7.1.6",
     "@hellosign/eslint-config": "^1.4.0",
     "babel-core": "^7.0.0-bridge.0",
diff --git a/webpack.config.js b/webpack.config.js
@@ -21,7 +21,11 @@ const config = {
     rules: [
       {
         test: /\.js$/,
-        exclude: /node_modules/,
+        // Ordinarily we would `exclude: /node_modules/`
+        // here, however some depdendencies use ES6 and
+        // other new syntax. To ensure that our lib works
+        // for as many users as possible, we pipe node
+        // modules through Babel as well. See #99.
         use: 'babel-loader',
       },
       {

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,11 @@ const config = {`
`21`	`21`	`rules: [`
`22`	`22`	`{`
`23`	`23`	`test: /\.js$/,`
`24`		`- exclude: /node_modules/,`
	`24`	+ // Ordinarily we would `exclude: /node_modules/`
	`25`	`+ // here, however some depdendencies use ES6 and`
	`26`	`+ // other new syntax. To ensure that our lib works`
	`27`	`+ // for as many users as possible, we pipe node`
	`28`	`+ // modules through Babel as well. See #99.`
`25`	`29`	`use: 'babel-loader',`
`26`	`30`	`},`
`27`	`31`	`{`