build with exiv2-0.28.0 #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exiv2-0.28.0 removed Exiv2::Image::AutoPtr and added Exiv2::Image::UniquePtr instead. since it's a typedef for std::unique_ptr<Image>, i'm using that directly instead of adding a condition on the exiv2 version.
exiv2-0.28.0 changed Exiv2::AnyError to Exiv2::Error.
|
@hellosiyan would you please take a look at this MR or #134? This way Viewnior can be built (and work) against newer versions of the Exiv2 library. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exiv2-0.28.0 replaced
Exiv2::Image::AutoPtrwithExiv2::Image::UniquePtr¹ andExiv2::AnyErrorwithExiv2::Error². this patch makes Viewnior build with 0.28.0 and 0.27.6.i have tested opening a JPEG image and looking at its EXIF metadata with both versions of exiv2.
¹
include/exiv2/image.hpp²
include/exiv2/error.hpp