Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User activity components #70

Merged
merged 3 commits into from
Apr 27, 2017
Merged

User activity components #70

merged 3 commits into from
Apr 27, 2017

Conversation

hellowin
Copy link
Owner

No description provided.

@@ -5,6 +5,7 @@ export type UserMetric = {
id: string,
name: string,
picture: string,
url?: string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected ':' and instead saw '?'.
Expected an identifier and instead saw ':'.
Expected '}' to match '{' from line 4 and instead saw 'string'.

// @flow
import React from 'react';
import Card from 'infra/component/Card';
import type { TimeRangeMetric } from '../service/timeRangeMetric';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Expected 'from' and instead saw '{'.
Expected '(string)' and instead saw 'TimeRangeMetric'.
Missing semicolon.
Unrecoverable syntax error. (4% scanned).

@@ -0,0 +1,95 @@
// @flow
import React from 'react';
import Card from 'infra/component/Card';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -0,0 +1,95 @@
// @flow
import React from 'react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@codecov
Copy link

codecov bot commented Apr 27, 2017

Codecov Report

Merging #70 into master will decrease coverage by 0.04%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #70      +/-   ##
=========================================
- Coverage   21.54%   21.5%   -0.05%     
=========================================
  Files          43      44       +1     
  Lines         478     493      +15     
  Branches      103     106       +3     
=========================================
+ Hits          103     106       +3     
- Misses        375     387      +12
Impacted Files Coverage Δ
src/infra/service/graph.js 20% <0%> (ø) ⬆️
src/domain/metric/service/userMetric.js 33.33% <0%> (ø) ⬆️
src/domain/metric/container/Summary.js 9.67% <100%> (+1.1%) ⬆️
src/domain/metric/component/UserActivityTop.js 15.78% <15.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235eb02...0f4fe55. Read the comment docs.

@hellowin hellowin merged commit 41d6aab into master Apr 27, 2017
@hellowin hellowin deleted the user-activity-components branch April 27, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants