[stable/vsphere-cpi]

[davidkarlsen]

Is your feature request related to a problem? Please describe.

1. Chart has hard-coded namespace kube-system - I believe this should be user-configurable (although it might very well be installed into kube-system by the user).

2. Security context should be configurable - ours is quite conservative on uid so if it can run as non-root that is preferable, as well as r/o root-filesystem.

3. taints and node-selector should be configurable, our masters are did not match the ones hard-coded in the chart.

Describe the solution you'd like
See above

Describe alternatives you've considered
N/A

Additional context
We run ICP 3.2.1 (IBM Cloud Private) - but the problems probably apply to any flavor of cluster.

Also: Should this chart perhaps move to https://github.com/vmware-tanzu/helm-charts ?

[davidkarlsen]

/assign @dvonthenen @frapposelli @andrewsykim

[k8s-ci-robot]

@davidkarlsen: GitHub didn't allow me to assign the following users: frapposelli, andrewsykim.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @dvonthenen @frapposelli @andrewsykim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidvonthenen]

Thanks @davidkarlsen for your feedback.

Will make changes for 1 and 3 and start looking into 2. I believe that the CPI can as non-root, but the CSI driver (chart doesn't exist yet), will require it because of the mount functionality.

[davidvonthenen]

Started implementation. Hope to have something soon.

[davidkarlsen]

Great. Do you have a vmware helm repo since this repo will retire soonish?
Since CSI is a distinct to-be chart I guess 2 could be fixed too?

[davidvonthenen]

PR submitted:
#20612

[davidvonthenen]

Great. Do you have a vmware helm repo since this repo will retire soonish?
Since CSI is a distinct to-be chart I guess 2 could be fixed too?

CSI driver chart has not gotten started yet. We also do hope to have this chart in a VMware helm repo soon.