Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

#11812 allow hostPath as datadir #11815

Merged
merged 2 commits into from
Feb 28, 2019
Merged

#11812 allow hostPath as datadir #11815

merged 2 commits into from
Feb 28, 2019

Conversation

micw
Copy link
Contributor

@micw micw commented Feb 27, 2019

What this PR does / why we need it:

  • allow hostPath as datadir for stable/redis-ha

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md (documented in values.yaml because the other persistence parameters are also only there)

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @micw. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2019
@micw
Copy link
Contributor Author

micw commented Feb 27, 2019

/assign @ssalaues

@k8s-ci-robot
Copy link
Contributor

@micw: GitHub didn't allow me to assign the following users: ssalaues.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ssalaues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2019
@evermind-micw
allow hostPath as datadir
dd3ada8 
Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2019
@ssalaues
Copy link
Collaborator

I think is a pretty interesting addition to the chart. I'll test out the behavior on my cluster since I don't have ok-to-test privilege.

ssalaues
ssalaues reviewed Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@ssalaues ssalaues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far my only concern is that this could essentially overwrite any folder on the host system and the description might need more explicit clarification to express this. In that enabling this will default to using root to chown the specified folder directly on the host machine to store the state (therefore bypassing the need for a PersistentVolume).

stable/redis-ha/values.yaml Outdated Show resolved Hide resolved
stable/redis-ha/templates/redis-ha-statefulset.yaml Show resolved Hide resolved
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2019
@evermind-micw
Better documentation for hostPath as datadir, make the chown init-con…
1a87470 
…tainer optional

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2019
@cpanato
Copy link
Member

cpanato commented Feb 28, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2019
@cpanato
Copy link
Member

cpanato commented Feb 28, 2019

@ssalaues are you ok with this change?

@ssalaues
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw, ssalaues

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit e2d9b91 into helm:master Feb 28, 2019
@ssalaues ssalaues mentioned this pull request Feb 28, 2019
Merged
3 tasks
cdenneen added a commit to cdenneen/charts that referenced this pull request Feb 28, 2019
@cdenneen
Merge branch 'master' of https://github.com/helm/charts into sslcerth…
2ca0fd2 
…ostpath

* 'master' of https://github.com/helm/charts: (1475 commits)
  added additional ports option for prometheus-operator prometheus service (helm#11506)
  [incubator/kafka] fix NOTES.txt: update script paths (helm#11503)
  helm#11812 allow hostPath as datadir (helm#11815)
  [stable/mongodb-replica-set] Fix metrics livenessProbe and regression in securityContext (helm#11819)
  [stable/mariadb] Add PodDisruptionBudget for MariaDB (helm#11417)
  fix hoard secrets id (helm#11835)
  fix: add missed template for serviceaccount and add basic RBAC resources (helm#11742)
  expose container port so it can be scraped (helm#11831)
  Feature/kuberhealthy pod annotations (helm#11651)
  [stable/prometheus-operator] Update deps for grafana v6 (helm#11824)
  [stable/auto-scaler] Add explicit awsRegion step in README (helm#11822)
  Add efs-provisioner mountOptions (helm#11821)
  fixes for kuberhealthy/kuberhealthy#121 (helm#11829)
  [stable/cockroachdb] Additional parameters for cockroachdb (helm#11747)
  Allow for overriding of proxy/admin listen (helm#11362)
  [stable/drupal] Add apiVersion in Chart.yaml and add test info to README.md (helm#11810)
  [stable/joomla] Add apiVersion in Chart.yaml and add test info to README.md (helm#11809)
  [stable/jasperreports] Add apiVersion in Chart.yaml and add test info to README.md (helm#11808)
  [stable/ghost] Add apiVersion in Chart.yaml and add test info to README.md (helm#11807)
  [stable/mariadb] Add apiVersion in Chart.yaml and add test info to README.md (helm#11806)
  ...
monotek pushed a commit to monotek/charts that referenced this pull request Mar 7, 2019
@micw
helm#11812 allow hostPath as datadir (helm#11815)
16b4fe6 
* allow hostPath as datadir

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>

* Better documentation for hostPath as datadir, make the chown init-container optional

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
alvgarvilla pushed a commit to alvgarvilla/charts that referenced this pull request Mar 13, 2019
@micw @alvgarvilla
helm#11812 allow hostPath as datadir (helm#11815)
aae7355 
* allow hostPath as datadir

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>

* Better documentation for hostPath as datadir, make the chown init-container optional

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
@micw micw mentioned this pull request Mar 20, 2019
Closed
@micw micw deleted the feature/11812 branch March 20, 2019 06:37
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
@micw @rmccorm4
helm#11812 allow hostPath as datadir (helm#11815)
6d99b82 
* allow hostPath as datadir

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>

* Better documentation for hostPath as datadir, make the chown init-container optional

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@micw @devnulled
helm#11812 allow hostPath as datadir (helm#11815)
2bc6446 
* allow hostPath as datadir

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>

* Better documentation for hostPath as datadir, make the chown init-container optional

Signed-off-by: Michael Wyraz <michael.wyraz@evermind.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssalaues ssalaues ssalaues left review comments

@cpanato cpanato Awaiting requested review from cpanato

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/redis-ha] feature: allow hostPath as datadir
6 participants
@micw @k8s-ci-robot @ssalaues @cpanato @helm-bot @evermind-micw