[stable/unifi] unifi chart enhancements #12047

billimek · 2019-03-10T14:20:06Z

What this PR does / why we need it:

based on the persistent nature of this chart, using a default strategy Type of 'Recreate' instead of 'RollingUpdate' - with an optional override
bumping unifi controller to the latest stable version (5.10.19)
adding @mcronce to the OWNERS file
updating label syntax to current helm standards (e.g.
app.kubernetes.io/name)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md

billimek · 2019-03-10T14:28:03Z

FYI @mcronce, adding you to the OWNERS file as part of this PR

billimek · 2019-03-10T15:11:54Z

Going to make some additional changes and re-submit

billimek · 2019-03-10T20:20:08Z

Re-opening after reviewing the StatefulSet section of the helm chart guidelines

mcronce · 2019-03-12T08:45:21Z

@billimek Received 👍

billimek · 2019-03-13T18:12:50Z

/assign @tompizmor

billimek · 2019-03-16T08:50:52Z

/assign @unguiculus

billimek · 2019-03-20T22:26:05Z

/assign @davidkarlsen

billimek · 2019-03-26T01:57:52Z

Hi friends, thank you so much for the really great discussion on this topic!

@unguiculus your amazing attention to detail is honestly really appreciated - thank you!

@davidkarlsen, @scottrigby, thanks for the additional feedback as well - this clarifies some misconceptions I had about when to use statefulsets.

Based on this discussion I'll update this PR (and the other two similar charts) to:

Use Deployment instead of StatefulSet as is the current mode
Default the upgrade strategy to be Recreate instead of RollingUpdate with the option to change this via a values parameter
Bump minor version instead of major given that it won't be a breaking change any more

Signed-off-by: Jeff Billimek <jeff@billimek.com>

billimek · 2019-03-27T10:34:58Z

@unguiculus & @davidkarlsen these changes are made, FYI!

unguiculus

The number of replicas should not longer be configurable.

stable/unifi/OWNERS

Signed-off-by: Jeff Billimek <jeff@billimek.com>

unguiculus · 2019-03-28T16:24:51Z

/lgtm

k8s-ci-robot · 2019-03-28T16:24:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/unifi/OWNERS~~ [billimek,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

unguiculus · 2019-03-28T16:25:08Z

/hold cancel

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com>

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com>

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com>

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com>

@mcronce

* switching unifi chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping unifi controller to the latest stable version (5.10.19) * adding @mcronce to the OWNERS file Signed-off-by: Jeff Billimek <jeff@billimek.com> * using volumeClaimTemplates for statefulSet * also updating label syntax to current helm standards (e.g. `app.kubernetes.io/name`) Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing indenting Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * include readme entry for strategyType Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count and add mcronce to Chart maintainers Signed-off-by: Jeff Billimek <jeff@billimek.com> * fixing linting error Signed-off-by: Jeff Billimek <jeff@billimek.com>

k8s-ci-robot requested review from foxish and sameersbn March 10, 2019 14:20

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2019

helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2019

billimek force-pushed the unifi-statefulset branch from 49f6a0a to 637f2a5 Compare March 10, 2019 14:20

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2019

billimek closed this Mar 10, 2019

billimek reopened this Mar 10, 2019

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2019

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2019

billimek force-pushed the unifi-statefulset branch from 44c48be to d3bbf6f Compare March 10, 2019 20:28

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2019

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2019

k8s-ci-robot assigned tompizmor Mar 13, 2019

k8s-ci-robot assigned unguiculus Mar 16, 2019

helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Mar 26, 2019

revert to Deployment and leverage strategy types

1523b5b

Signed-off-by: Jeff Billimek <jeff@billimek.com>

billimek force-pushed the unifi-statefulset branch from fd671ac to 1523b5b Compare March 26, 2019 02:22

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 26, 2019

include readme entry for strategyType

8552b96

Signed-off-by: Jeff Billimek <jeff@billimek.com>

billimek changed the title ~~[stable/unifi] switching unifi chart to SatefulSet~~ [stable/unifi] unifi chart enhancements Mar 26, 2019

unguiculus suggested changes Mar 27, 2019

View reviewed changes

stable/unifi/OWNERS Show resolved Hide resolved

hard-code replica count and add mcronce to Chart maintainers

d71fa14

Signed-off-by: Jeff Billimek <jeff@billimek.com>

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2019

fixing linting error

276661f

Signed-off-by: Jeff Billimek <jeff@billimek.com>

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2019

unguiculus approved these changes Mar 28, 2019

View reviewed changes

k8s-ci-robot merged commit 5f03f4e into helm:master Mar 28, 2019

billimek deleted the unifi-statefulset branch March 29, 2019 01:07

billimek mentioned this pull request May 4, 2019

Feature/unifi statefulset #13518

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/unifi] unifi chart enhancements #12047

[stable/unifi] unifi chart enhancements #12047

billimek commented Mar 10, 2019 •

edited

Loading

billimek commented Mar 10, 2019

billimek commented Mar 10, 2019

billimek commented Mar 10, 2019

mcronce commented Mar 12, 2019

billimek commented Mar 13, 2019

billimek commented Mar 16, 2019

billimek commented Mar 20, 2019

billimek commented Mar 26, 2019

billimek commented Mar 27, 2019

unguiculus left a comment

unguiculus commented Mar 28, 2019

k8s-ci-robot commented Mar 28, 2019

unguiculus commented Mar 28, 2019

[stable/unifi] unifi chart enhancements #12047

[stable/unifi] unifi chart enhancements #12047

Conversation

billimek commented Mar 10, 2019 • edited Loading

What this PR does / why we need it:

Checklist

billimek commented Mar 10, 2019

billimek commented Mar 10, 2019

billimek commented Mar 10, 2019

mcronce commented Mar 12, 2019

billimek commented Mar 13, 2019

billimek commented Mar 16, 2019

billimek commented Mar 20, 2019

billimek commented Mar 26, 2019

billimek commented Mar 27, 2019

unguiculus left a comment

Choose a reason for hiding this comment

unguiculus commented Mar 28, 2019

k8s-ci-robot commented Mar 28, 2019

unguiculus commented Mar 28, 2019

billimek commented Mar 10, 2019 •

edited

Loading