Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/registry-creds] Add registry-creds chart #13660

Closed
wants to merge 2 commits into from
Closed

[incubator/registry-creds] Add registry-creds chart #13660

wants to merge 2 commits into from

Conversation

kir4h
Copy link
Contributor

@kir4h kir4h commented May 9, 2019

Signed-off-by: Andres Alvarez 1671935+kir4h@users.noreply.github.com

What this PR does / why we need it:

This PR creates a chart to bootstraps a registry-creds deployment on a Kubernetes cluster

Special notes for your reviewer:

This is the first chart I create so any feedback is welcome. I have tried to follow the suggested guides as much as possible from my knowledge.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

Signed-off-by: Andres Alvarez <1671935+kir4h@users.noreply.github.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kir4h
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

If they are not already assigned, you can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @kir4h. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
Signed-off-by: Andres Alvarez <1671935+kir4h@users.noreply.github.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
@kir4h
Copy link
Contributor Author

kir4h commented May 10, 2019

/assign @prydonius

@kir4h
Copy link
Contributor Author

kir4h commented May 16, 2019

@prydonius anything else I can do to ease up the reviewal?

@maorfr
Copy link
Member

maorfr commented May 16, 2019

hey @kir4h

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

@kir4h
Copy link
Contributor Author

kir4h commented May 16, 2019

hey @kir4h

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

Nope, I'm not the owner of registry-creds so didn't even think about hosting it. I don't currently have any helm repo to host it so hosting it here seemed more convenient. But I can try to find a solution if required.

I noticed lot of projects moving out and being hosted independently; is this being encouraged from helm/charts or just an option for orgs that want to host their own charts for flexibility?

@maorfr
Copy link
Member

maorfr commented May 16, 2019

a bit of both. check this out:
https://helm.sh/blog/intro-helm-hub/

@kir4h
Copy link
Contributor Author

kir4h commented May 23, 2019

Closing PR as the chart is now hosted in Github pages and discoverable through Helm hub (helm/hub#88)

@kir4h kir4h closed this May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants