-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/minio] add namespace metadata #13933
Conversation
Hi @eh-am. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eh-am: GitHub didn't allow me to assign the following users: wlan0. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eh-am Thanks for the PR. It LGTM. Could you please rebase with master. |
shoot I messed up with the branch I think, let me fix it |
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: eduardo aleixo <eduardoaleixomartins@gmail.com>
ff90a13
to
40e531a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eh-am If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
Signed-off-by: eduardo aleixo eduardoaleixomartins@gmail.com
What this PR does / why we need it:
this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553
Special notes for your reviewer:
Checklist
[stable/chart]