Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minio] add namespace metadata #13933

Closed
wants to merge 1 commit into from

Conversation

eh-am
Copy link
Contributor

@eh-am eh-am commented May 16, 2019

Signed-off-by: eduardo aleixo eduardoaleixomartins@gmail.com

What this PR does / why we need it:

this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @eh-am. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@eh-am: GitHub didn't allow me to assign the following users: wlan0.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wlan0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wlan0
Copy link
Collaborator

wlan0 commented May 21, 2019

@eh-am Thanks for the PR. It LGTM. Could you please rebase with master.

@helm-bot helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2019
@eh-am
Copy link
Contributor Author

eh-am commented May 21, 2019

shoot I messed up with the branch I think, let me fix it

this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Signed-off-by: eduardo aleixo <eduardoaleixomartins@gmail.com>
@helm-bot helm-bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eh-am
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wlan0

If they are not already assigned, you can assign the PR to them by writing /assign @wlan0 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2019
@eh-am
Copy link
Contributor Author

eh-am commented May 21, 2019

@dperetti sorry, what do you mean?

@wlan0 should be fine now!

@wlan0
Copy link
Collaborator

wlan0 commented May 23, 2019

Thanks @eh-am. LGTM. I might have to ask you to rebase one more time if one of these PRs gets merged first (#13087, #14097). I'll keep you posted!

@stale
Copy link

stale bot commented Jun 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2019
@stale
Copy link

stale bot commented Jul 6, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants