Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-mysql-exporter] updated gce-proxy to 1.14 & added myself to maintainers & owners #14776

Merged
merged 2 commits into from
Jun 16, 2019

Conversation

monotek
Copy link
Collaborator

@monotek monotek commented Jun 13, 2019

Signed-off-by: André Bauer andre.bauer@kiwigrid.com

What this PR does / why we need it:

  • updated gce-proxy to 1.14
  • added myself to maintainers
  • added owners file

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

#13869

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

André Bauer added 2 commits June 13, 2019 10:28
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 13, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @monotek. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2019
@monotek
Copy link
Collaborator Author

monotek commented Jun 13, 2019

/assign @Juanchimienti
/assign @viglesiasce

@k8s-ci-robot
Copy link
Contributor

@monotek: GitHub didn't allow me to assign the following users: juanchimienti.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Juanchimienti
/assign @viglesiasce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@koolamusic
Copy link

/assign @koolamusic

@k8s-ci-robot
Copy link
Contributor

@koolamusic: GitHub didn't allow me to assign the following users: koolamusic.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @koolamusic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tklovett
Copy link
Contributor

Thanks for getting these changes in @monotek – I'm happy to be an OWNER too if that is useful

@maorfr
Copy link
Member

maorfr commented Jun 16, 2019

/ok-to-test
/lgtm

thanks a good luck!

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 763df22 into helm:master Jun 16, 2019
fooka03 pushed a commit to fooka03/charts that referenced this pull request Jun 17, 2019
…myself to maintainers & owners (helm#14776)

* updated gce-proxy to 1.14 & added myself to maintainers & owners

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

* bumped chart version

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: Nigel Foucha <nigel.foucha@gmail.com>
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
…myself to maintainers & owners (helm#14776)

* updated gce-proxy to 1.14 & added myself to maintainers & owners

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

* bumped chart version

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants