[stable/minecraft] enable deployment annotations, bump chart version #21502

carpenike · 2020-03-17T17:06:54Z

Deployment annotations used for things like backup. istio, etc.

Signed-off-by: Ryan Holt ryan@ryanholt.net

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

k8s-ci-robot · 2020-03-17T17:07:09Z

Hi @carpenike. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

carpenike · 2020-03-17T17:07:38Z

@billimek, would love a review if you've got a second.

billimek · 2020-03-17T17:07:56Z

/ok-to-test

billimek · 2020-03-17T17:08:15Z

/lgtm

k8s-ci-robot · 2020-03-17T17:08:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, carpenike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/minecraft/OWNERS~~ [billimek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com>

…template (#21510) * enable deployment annotations, bump chart version (#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com>

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

…template (helm#21510) * enable deployment annotations, bump chart version (helm#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (helm#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (helm#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (helm#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (helm#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com>

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

…template (helm#21510) * enable deployment annotations, bump chart version (helm#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (helm#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (helm#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (helm#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (helm#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com>

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

…template (helm#21510) * enable deployment annotations, bump chart version (helm#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (helm#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (helm#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (helm#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (helm#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com>

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>

…template (helm#21510) * enable deployment annotations, bump chart version (helm#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (helm#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (helm#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (helm#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (helm#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

…template (helm#21510) * enable deployment annotations, bump chart version (helm#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (helm#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (helm#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (helm#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (helm#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

enable deployment annotations, bump chart version

be10f7d

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2020

k8s-ci-robot requested review from billimek and gtaylor March 17, 2020 17:07

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2020

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2020

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020

k8s-ci-robot merged commit 9025b6c into helm:master Mar 17, 2020

omerli pushed a commit to omerli/charts that referenced this pull request Mar 19, 2020

enable deployment annotations, bump chart version (helm#21502)

e3df274

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com>

fowlie pushed a commit to fowlie/charts that referenced this pull request Mar 20, 2020

enable deployment annotations, bump chart version (helm#21502)

333a85c

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020

enable deployment annotations, bump chart version (helm#21502)

444992c

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020

enable deployment annotations, bump chart version (helm#21502)

2162897

Signed-off-by: Ryan Holt <ryan@ryanholt.net>

li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020

enable deployment annotations, bump chart version (helm#21502)

3fb6217

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>

mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020

enable deployment annotations, bump chart version (helm#21502)

7599723

Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/minecraft] enable deployment annotations, bump chart version #21502

[stable/minecraft] enable deployment annotations, bump chart version #21502

carpenike commented Mar 17, 2020 •

edited

Loading

k8s-ci-robot commented Mar 17, 2020

carpenike commented Mar 17, 2020

billimek commented Mar 17, 2020

billimek commented Mar 17, 2020

k8s-ci-robot commented Mar 17, 2020

[stable/minecraft] enable deployment annotations, bump chart version #21502

[stable/minecraft] enable deployment annotations, bump chart version #21502

Conversation

carpenike commented Mar 17, 2020 • edited Loading

Is this a new chart

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

k8s-ci-robot commented Mar 17, 2020

carpenike commented Mar 17, 2020

billimek commented Mar 17, 2020

billimek commented Mar 17, 2020

k8s-ci-robot commented Mar 17, 2020

carpenike commented Mar 17, 2020 •

edited

Loading