-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kube-slack] To run kube-slack as non root #21967
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierluigilenoci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pierluigilenoci. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
@pierluigilenoci Thanks for your PR. Accoding to the current Dockerfile the container would already be running as non-root. Why exactly would the proposed change be necessary? If you want to move forward with this PR please merge the newest changes from your previous commit also. |
@jstriebel according to my knowledge if you use an "alphanumeric" user you get this error from K8s: "container has runAsNonRoot and image has non-numeric user (%s), cannot verify user is non-root". So we need to add a securityContext inside the deployment with a proper runAsUser parameter. |
Recreate the PR here #21983 |
What this PR does / why we need it:
To run kube-slack as non root
Which issue this PR fixes
No issue to fix, only an improvement
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)