[incubator/azuremonitor-containers] updates for hotfix agent release ciprod09252020 & win-ciprod09252020

[ganga1980]

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.
No

What this PR does / why we need it:

This PR has fix for mdm metric issue which found lately.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @ganga1980. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ganga1980]

Hi, @scottrigby, can you please help on approving this PR and looks like @lachie83 on PTO? I appreciate your help on this.

[ganga1980]

Hi, @scottrigby, can you please help on reviewing this PR? your help much appreciated on this.

[scottrigby]

Hi @ganga1980 I see you've contributed all of the changes to this chart. I would suggest adding you as a maintainer. For now I'll help with this PR.

However, perhaps nearly as pressing, are you aware of the stable and incubator repo deprecation deadline? See https://github.com/helm/charts/issues/21103 for a list of stable charts status moving to new chart repos. There isn't yet a similar one for incubator, due to stable charts priority.

Would you be interested in adding this chart to the Microsoft chart repo and helping to maintain it there? https://github.com/microsoft/charts. I just added an issue there: microsoft/charts#19 Would you want to join that discussion?

[scottrigby]

/ok-to-test

[ganga1980]

Hi @ganga1980 I see you've contributed all of the changes to this chart. I would suggest adding you as a maintainer. For now I'll help with this PR.

However, perhaps more pressing, are you aware of the stable and incubator repo deprecation deadline? See #21103 for a list of stable charts status moving to new chart repos. There isn't yet a similar one for incubator, due to stable charts priority.

Would you be interested in adding this chart to the Microsoft chart repo and helping to maintain it there? https://github.com/microsoft/charts. I just added an issue there: microsoft/charts#19 Would you want to join that discussion?
@scottrigby , thanks for your help on this. Sure, I can add this chart to Microsoft chart repos since this repo in deprecation path as you have mentioned.

[scottrigby]

@ganga1980 great! If you would like to make the PR, I would recommend following these steps to bring in git history (will be forming into a blog post very soon, in the meantime see this issue): prometheus-community/helm-charts#3. Please also @ me in the PR.

Alternatively I'm happy to do it, as I have the process mostly automated. Please just let me know 😄

[scottrigby]

For this PR, merging
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ganga1980, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• incubator/azuremonitor-containers/OWNERS [scottrigby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vishiy]

@scottrigby - can you please point to the new repo ?

[scottrigby]

@vishiy you commented on an issue in the new repo microsoft/charts#19 (comment) I added further details in response. Hope that clears it up.

[ganga1980]

@vishiy you commented on an issue in the new repo microsoft/charts#19 (comment) I added further details in response. Hope that clears it up.

@scottrigby, we have moved our chart to microsoft/chart repo. are you guys putting some instructions to redirect to microsoft/chart repo or we need to take care of adding link in our chart readme?

[scottrigby]

@ganga1980 interesting, I don't see them at https://github.com/microsoft/charts/tree/master/repo. The issue I have opened in that repo also hasn't been addressed.