-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nexeck Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
e5b7dd7
to
727e95a
Compare
/assign @viglesiasce |
cc @william-tran for additional review /ok-to-test |
Should the image tag in the readme be updated as well? |
I was working through stability issues with our upgrade to 3.8 but I think we're looking good now. The issue is caused by the reduction of available DB connections for worker scheduling requests, from a shared pool of 64 with API requests, to each having their own pool of 32 DB connections. This forced us to increase the concourse-web replicas from 1 to 3, which resulted in lots of 'unknown handle' errors being logged by workers from multiple concourse-webs doing garbage collection on the same volumes. This would cause the workers to restart unnecessarily. I'd like to lump in the chart changes that improve stability along with a 3.8.0 upgrade. |
727e95a
to
b997e88
Compare
@mattfarina i have updated the README. |
@nexeck I'd like to wait for @william-tran and @viglesiasce on this one as they are the maintainers of the chart itself. If they don't get to it I (or one of the other chart repo maintainers of which @viglesiasce is one) will come back around to it. |
I've made another PR #3203 that supersedes this one, as going to 3.8 requires changes to how we manage worker lifecycle. |
Closed, see #3203 |
This PR will upgrade concourse to version 3.8.0