Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/concourse] Upgrade to 3.8.0 #3082

Closed
wants to merge 1 commit into from

Conversation

nexeck
Copy link
Contributor

@nexeck nexeck commented Dec 18, 2017

This PR will upgrade concourse to version 3.8.0

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nexeck
We suggest the following additional approver: viglesiasce

Assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nexeck
Copy link
Contributor Author

nexeck commented Dec 18, 2017

/assign @viglesiasce

@viglesiasce
Copy link
Contributor

cc @william-tran for additional review

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2017
@mattfarina
Copy link
Contributor

Should the image tag in the readme be updated as well?

@william-tran
Copy link
Collaborator

I was working through stability issues with our upgrade to 3.8 but I think we're looking good now. The issue is caused by the reduction of available DB connections for worker scheduling requests, from a shared pool of 64 with API requests, to each having their own pool of 32 DB connections. This forced us to increase the concourse-web replicas from 1 to 3, which resulted in lots of 'unknown handle' errors being logged by workers from multiple concourse-webs doing garbage collection on the same volumes. This would cause the workers to restart unnecessarily. I'd like to lump in the chart changes that improve stability along with a 3.8.0 upgrade.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2017
@nexeck
Copy link
Contributor Author

nexeck commented Dec 20, 2017

@mattfarina i have updated the README.

@mattfarina
Copy link
Contributor

mattfarina commented Dec 20, 2017

@nexeck I'd like to wait for @william-tran and @viglesiasce on this one as they are the maintainers of the chart itself. If they don't get to it I (or one of the other chart repo maintainers of which @viglesiasce is one) will come back around to it.

@william-tran
Copy link
Collaborator

I've made another PR #3203 that supersedes this one, as going to 3.8 requires changes to how we manage worker lifecycle.

@nexeck
Copy link
Contributor Author

nexeck commented Jan 3, 2018

Closed, see #3203

@nexeck nexeck closed this Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants